T7936: Drop sFlow plugin from VPP and use native sFlow plugin - #1060
Merged
Conversation
VPP 25.06 has own sFlow plugin, we do not need to build external plugin
|
👍 |
zdc
approved these changes
Oct 16, 2025
zdc
left a comment
zdc
left a comment
Contributor
There was a problem hiding this comment.
This change is OK.
It just needs to be double-checked for any API difference between the built-in and these versions.
natali-rs1985
approved these changes
Oct 17, 2025
natali-rs1985
left a comment
natali-rs1985
left a comment
Contributor
There was a problem hiding this comment.
No API difference between the built-in and current version.
vyosbot
added
mirror-initiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
VPP 25.06 has its own sFlow plugin; we do not need to build an external plugin
https://github.com/FDio/vpp/tree/stable/2506/src/plugins/sflow
Types of changes
Related Task(s)
Related PR(s)
Checklist: